Skip to content

Revert PR #51563 - #51656

Closed
mandrenguyen wants to merge 1 commit into
cms-sw:masterfrom
mandrenguyen:revert_PR51563
Closed

Revert PR #51563 #51656
mandrenguyen wants to merge 1 commit into
cms-sw:masterfrom
mandrenguyen:revert_PR51563

Conversation

@mandrenguyen

@mandrenguyen mandrenguyen commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Reverting this PR related to TICLGeom in the interest of building the next CMSSW_20_1_0 pre-release.

Apologies to @felicepantaleo

mandrenguyen mandrenguyen
Revert "Merge pull request cms-sw#51563 from felicepantaleo/TICLGeom_…
fcbbf58 
…20_1_X"

This reverts commit 986faf7, reversing
changes made to 414ae03.
@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Aug 9, 2026
@cmsbuild

cmsbuild commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mandrenguyen

mandrenguyen commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51656/50520

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

  • CondFormats/HGCalObjects (alca, db)
  • DPGAnalysis/HGCalNanoAOD (xpog)
  • HLTrigger/Configuration (hlt)
  • PhysicsTools/TruthInfo (generators)
  • RecoEgamma/EgammaTools (reconstruction)
  • RecoHGCal/TICL (reconstruction)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (reconstruction)
  • RecoLocalCalo/HGCalRecProducers (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (simulation)
  • Validation/HGCalValidation (dqm)

@Alejandro1400, @EltonSh, @JanChyczynski, @Martin-Grunewald, @Moanwar, @arunhep, @battibass, @civanch, @ctarricone, @francescobrivio, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @perrotta, @rseidita, @sensrcn, @srimanob, @theofil can you please review it and eventually sign? Thanks.
@IzaakWN, @JanChyczynski, @Martin-Grunewald, @PonIlya, @Prasant1993, @ReyerBand, @Sam-Harper, @SohamBhattacharya, @VourMa, @a-kapoor, @afiqaize, @apsallid, @argiro, @azotz, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @jainshilpi, @lecriste, @lgray, @mbluj, @missirol, @mmarionncern, @mmusich, @pfs, @ram1123, @rchatter, @rovere, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @sobhatta, @thomreis, @tocheng, @valsdav, @vandreev11, @varuns23, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild mentioned this pull request Aug 9, 2026
Merged
@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9884c/55200/summary.html
COMMIT: fcbbf58
CMSSW: CMSSW_20_1_X_2026-08-09-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51656/55200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3589140
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589103
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 11 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step3 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step2 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing step2 max memory diff -318.4 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step2 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step3 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step3 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step2 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step3 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step2 max memory diff -318.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step3 max memory diff -318.6 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step2 max memory diff -318.5 exceeds +/- 30.0 MiB

@felicepantaleo

felicepantaleo commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

hi @mandrenguyen, I have a fix in #51657
running the tests now

@mandrenguyen

mandrenguyen commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

hi @mandrenguyen, I have a fix in #51657 running the tests now

Excellent, thank you! Will close this PR once we get #51657 in.

@mmusich

mmusich commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

-hlt

@mandrenguyen

mandrenguyen commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #51657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alca-pending code-checks-approved db-pending dqm-pending generators-pending hlt-rejected orp-pending pending-signatures reconstruction-pending simulation-pending tests-approved xpog-pending

Projects

None yet

Milestone

CMSSW_20_1_X

Development

Successfully merging this pull request may close these issues.

4 participants

@mandrenguyen @cmsbuild @felicepantaleo @mmusich